alex/irc-greeter-bot
Watch
1
1
Fork
You've already forked irc-greeter-bot
 0
generated from alex/base-template
Code Issues 1 Pull requests Packages 1 Activity Actions

fix: stop posting horse fact on every boot #16

Merged
alex merged 1 commit from pi/issue15-1785124021180 into master 2026-07-27 03:52:54 +00:00
Conversation 0 Commits 1 Files changed 3 +14 -133
pi commented 2026-07-27 03:47:02 +00:00
Contributor
Copy link

Fixes #15

The bot no longer posts a random horse fact when it joins a channel, which
happened on every boot and on every reconnect (once per channel). The daily
local-midnight broadcast (broadcastFact via startDailyMidnight) already
provides the "lossy daily reminder," so the on-join trigger is redundant noise.

Changes

  • src/main.ts: removed handleBotJoin and its HandleBotJoinResult
    type, and removed the call to it from the join event handler in
    createClient. The daily midnight scheduler and broadcastFact are
    untouched.
  • src/main_test.ts: removed the handleBotJoin tests and its import;
    kept the broadcastFact tests (including Chatto mirroring).
  • README.md: updated the "Daily horse facts" section to reflect that
    facts are now broadcast only at local midnight, and removed references to the
    per-join trigger.

Newcomer greetings and feed announcements are unaffected. All 161 tests pass,
and deno check, deno lint, deno fmt, and fallow dead-code are clean.

Fixes #15 The bot no longer posts a random horse fact when it joins a channel, which happened on every boot and on every reconnect (once per channel). The daily local-midnight broadcast (`broadcastFact` via `startDailyMidnight`) already provides the "lossy daily reminder," so the on-join trigger is redundant noise. ## Changes - **`src/main.ts`**: removed `handleBotJoin` and its `HandleBotJoinResult` type, and removed the call to it from the `join` event handler in `createClient`. The daily midnight scheduler and `broadcastFact` are untouched. - **`src/main_test.ts`**: removed the `handleBotJoin` tests and its import; kept the `broadcastFact` tests (including Chatto mirroring). - **`README.md`**: updated the "Daily horse facts" section to reflect that facts are now broadcast only at local midnight, and removed references to the per-join trigger. Newcomer greetings and feed announcements are unaffected. All 161 tests pass, and `deno check`, `deno lint`, `deno fmt`, and `fallow dead-code` are clean.
fix: stop posting horse fact on every boot
All checks were successful
PR / deno (pull_request) Successful in 22s
Details
PR / fallow (pull_request) Successful in 25s
Details
Build and Push Container Image / build-and-push-1 (push) Successful in 51s
Details
Build and Push Container Image / build-and-push (push) Successful in 0s
Details
Build and Push Container Image / deploy-1 (push) Successful in 4s
Details
Build and Push Container Image / deploy (push) Successful in 0s
Details
47d27c5f17 
Co-authored-by: alex <alex@forge.l3x.in>
alex merged commit 47d27c5f17 into master 2026-07-27 03:52:54 +00:00
alex deleted branch pi/issue15-1785124021180 2026-07-27 03:52:55 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
dependencies
Renovate stuff

No labels
dependencies
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
alex/irc-greeter-bot!16
No description provided.